native support for modal cloud from CLI #2237
Open
+524
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesfrye
reviewed
Jan 7, 2025
charlesfrye
reviewed
Jan 7, 2025
|
I think we also need to figure out pushing local datasets to modal too for this feature. |
NanoCode012
reviewed
Jan 10, 2025
| if wandb_project: | ||
| wandb_args.append(f"project={wandb_project}") | ||
| if wandb_entity: | ||
| wandb_args.append(f"entity={wandb_entity}") |
There was a problem hiding this comment.
I noticed these two args for wandb, how about wandb_name?
|
|
||
| if family == "l40s": | ||
| return modal.gpu.L40S(count=count) | ||
| if family == "a100": |
There was a problem hiding this comment.
Following convention for 80gb, should this be "a100-40gb"?
| if env := self.get_env(): | ||
| image = image.env(env) | ||
|
|
||
| image = image.pip_install("fastapi==0.110.0", "pydantic==2.6.3") |
| return res | ||
|
|
||
| def get_image(self): | ||
| docker_tag = "main-py3.11-cu124-2.5.1" |
There was a problem hiding this comment.
Should we default to the stable tag or keep latest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.